Canopy - SCA #2 - Canopy


Prepared by:

Halborn Logo

HALBORN

Last Updated 07/31/2025

Date of Engagement: June 18th, 2025 - July 1st, 2025

Summary

100% of all REPORTED Findings have been addressed

All findings

14

Critical

0

High

0

Medium

2

Low

4

Informational

8


1. Introduction

Canopy engaged Halborn to conduct a security assessment of some packages for Movement blockchain, beginning on June 18th, 2025, and ending on July 1st, 2025. This security assessment focused on the smart contracts within the Satay-movement GitHub repository, commit hashes, and further details can be found in the Scope section of this report. The primary focus of this audit is to review the new Meridian strategy and a newly implemented rewards notification feature within the LayerBank and Echelon strategies.


Canopy is a yield aggregator on the Movement network that enables efficient interaction with multiple DeFi protocols through modular strategies composed of predefined operations. It also provides automated vaults that optimize fund allocations and rebalance strategy debt ratios, offering a streamlined approach to yield generation with reduced user intervention.


2. Caveat

All remediations described in this report were completed prior to the following commit, which serves as a consolidated snapshot of the final codebase. This commit also includes some additional modifications that do not impact the security of the project. While remediations may have been implemented across multiple earlier commits, this single commit includes all relevant changes and can be used for verification purposes:

1ad23ffefe263ce88de0a328952af41e22c1c1ff


3. Assessment Summary

The team at Halborn assigned a full-time security engineer to verify the security of the smart contracts. The security engineer is a blockchain and smart-contract security expert with advanced penetration testing, smart-contract hacking, and deep knowledge of multiple blockchain protocols.

The purpose of this assessment is to:

    • Ensure that smart contract functions operate as intended.

    • Identify potential security issues with the smart contracts.



In summary, Halborn identified some improvements to reduce the likelihood and impact of risks, which were mostly addressed by the Canopy team. The main ones were the following: 

    • Make the withdraw_fa function publicly accessible in the Meridian strategy and add proper authorization checks to allow fee recipients to withdraw their strategy shares.

    • Create a deposit function that allows Meridian strategy deposits to be handled through the appropriate FA path while supporting the required CoinType parameter.

    • Add validation in the rewards notification functions to skip processing when the reward asset matches the strategy's base asset.

    • Fix the claim_behalf function to query balances from the on_behalf_of address instead of the signer's address when calculating claimed rewards.

4. Test Approach and Methodology

Halborn performed a combination of the manual view of the code and automated security testing to balance efficiency, timeliness, practicality, and accuracy regarding the scope of the smart contract assessment. While manual testing is recommended to uncover flaws in logic, process, and implementation, automated testing techniques help enhance the coverage of smart contracts. They can quickly identify items that do not follow security best practices. The following phases and associated tools were used throughout the term of the assessment:

    • Research into the architecture, purpose, and use of the platform.

    • Manual code review and walkthrough.

    • Manual assessment of the critical Move variables and functions in scope to identify any vulnerability classes related to arithmetic or logic.

    • Cross-contract call controls.

    • Logical controls related to the platform architecture.

    • Integration testing using the Aptos Framework.


5. Caveat

While the audit team conducted a thorough static review and manual analysis, dynamic validation (e.g., automated test execution or proof-of-concept reproduction) could not be performed due to technical constraints outside the scope of this engagement. Specifically, a build error caused by third-party package dependencies prevented the execution of the existing test suite within the audit environment.

As a result, end-to-end tests could not be executed, and certain behaviors could not be verified through runtime instrumentation. Although this limited the ability to validate some edge cases dynamically, the findings presented are based on careful source code analysis and reflect the issues observable through that approach.

6. RISK METHODOLOGY

Every vulnerability and issue observed by Halborn is ranked based on two sets of Metrics and a Severity Coefficient. This system is inspired by the industry standard Common Vulnerability Scoring System.
The two Metric sets are: Exploitability and Impact. Exploitability captures the ease and technical means by which vulnerabilities can be exploited and Impact describes the consequences of a successful exploit.
The Severity Coefficients is designed to further refine the accuracy of the ranking with two factors: Reversibility and Scope. These capture the impact of the vulnerability on the environment as well as the number of users and smart contracts affected.
The final score is a value between 0-10 rounded up to 1 decimal place and 10 corresponding to the highest security risk. This provides an objective and accurate rating of the severity of security vulnerabilities in smart contracts.
The system is designed to assist in identifying and prioritizing vulnerabilities based on their level of risk to address the most critical issues in a timely manner.

6.1 EXPLOITABILITY

Attack Origin (AO):
Captures whether the attack requires compromising a specific account.
Attack Cost (AC):
Captures the cost of exploiting the vulnerability incurred by the attacker relative to sending a single transaction on the relevant blockchain. Includes but is not limited to financial and computational cost.
Attack Complexity (AX):
Describes the conditions beyond the attacker’s control that must exist in order to exploit the vulnerability. Includes but is not limited to macro situation, available third-party liquidity and regulatory challenges.
Metrics:
EXPLOITABILITY METRIC (mem_e)METRIC VALUENUMERICAL VALUE
Attack Origin (AO)Arbitrary (AO:A)
Specific (AO:S)
1
0.2
Attack Cost (AC)Low (AC:L)
Medium (AC:M)
High (AC:H)
1
0.67
0.33
Attack Complexity (AX)Low (AX:L)
Medium (AX:M)
High (AX:H)
1
0.67
0.33
Exploitability EE is calculated using the following formula:

E=meE = \prod m_e

6.2 IMPACT

Confidentiality (C):
Measures the impact to the confidentiality of the information resources managed by the contract due to a successfully exploited vulnerability. Confidentiality refers to limiting access to authorized users only.
Integrity (I):
Measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of data stored and/or processed on-chain. Integrity impact directly affecting Deposit or Yield records is excluded.
Availability (A):
Measures the impact to the availability of the impacted component resulting from a successfully exploited vulnerability. This metric refers to smart contract features and functionality, not state. Availability impact directly affecting Deposit or Yield is excluded.
Deposit (D):
Measures the impact to the deposits made to the contract by either users or owners.
Yield (Y):
Measures the impact to the yield generated by the contract for either users or owners.
Metrics:
IMPACT METRIC (mIm_I)METRIC VALUENUMERICAL VALUE
Confidentiality (C)None (C:N)
Low (C:L)
Medium (C:M)
High (C:H)
Critical (C:C)
0
0.25
0.5
0.75
1
Integrity (I)None (I:N)
Low (I:L)
Medium (I:M)
High (I:H)
Critical (I:C)
0
0.25
0.5
0.75
1
Availability (A)None (A:N)
Low (A:L)
Medium (A:M)
High (A:H)
Critical (A:C)
0
0.25
0.5
0.75
1
Deposit (D)None (D:N)
Low (D:L)
Medium (D:M)
High (D:H)
Critical (D:C)
0
0.25
0.5
0.75
1
Yield (Y)None (Y:N)
Low (Y:L)
Medium (Y:M)
High (Y:H)
Critical (Y:C)
0
0.25
0.5
0.75
1
Impact II is calculated using the following formula:

I=max(mI)+mImax(mI)4I = max(m_I) + \frac{\sum{m_I} - max(m_I)}{4}

6.3 SEVERITY COEFFICIENT

Reversibility (R):
Describes the share of the exploited vulnerability effects that can be reversed. For upgradeable contracts, assume the contract private key is available.
Scope (S):
Captures whether a vulnerability in one vulnerable contract impacts resources in other contracts.
Metrics:
SEVERITY COEFFICIENT (CC)COEFFICIENT VALUENUMERICAL VALUE
Reversibility (rr)None (R:N)
Partial (R:P)
Full (R:F)
1
0.5
0.25
Scope (ss)Changed (S:C)
Unchanged (S:U)
1.25
1
Severity Coefficient CC is obtained by the following product:

C=rsC = rs

The Vulnerability Severity Score SS is obtained by:

S=min(10,EIC10)S = min(10, EIC * 10)

The score is rounded up to 1 decimal places.
SeverityScore Value Range
Critical9 - 10
High7 - 8.9
Medium4.5 - 6.9
Low2 - 4.4
Informational0 - 1.9

7. SCOPE

REPOSITORY
(a) Repository: satay-movement
(b) Assessed Commit ID: 88b2d60
(c) Items in scope:
  • packages/strategies/echelon_simple/sources/strategy.rs
  • packages/strategies/layerbank_simple/sources/strategy.rs
  • packages/strategies/meridian_rewards/sources/strategy.rs
↓ Expand ↓
Out-of-Scope: Third party dependencies and economic attacks.
Remediation Commit ID:
Out-of-Scope: New features/implementations after the remediation commit IDs.

8. Assessment Summary & Findings Overview

Critical

0

High

0

Medium

2

Low

4

Informational

8

Security analysisRisk levelRemediation Date
Fee Recipients Cannot Access Earned Fees in Meridian StrategyMediumSolved - 07/09/2025
Router's Meridian Strategy Deposit Path Mismatch Makes Strategy InaccessibleMediumSolved - 07/09/2025
Reward Notification Lacks Base Asset Exclusion CheckLowSolved - 07/07/2025
Incorrect Balance Query in LayerBank Airdrop Block's claim_behalf FunctionLowSolved - 07/07/2025
Inconsistent Error Codes Across Strategy ImplementationsLowRisk Accepted - 07/07/2025
Permanent Upkeep Interval Limitation in LayerBank and Echelon StrategiesLowSolved - 07/07/2025
Missing Validation of Rewards Pool AddressInformationalSolved - 07/09/2025
Missing Validation of Upkeep Interval ThresholdsInformationalSolved - 07/07/2025
Redundant State Update in Initial Rewards Pool AssignmentInformationalSolved - 07/07/2025
Missing Zero Amount Validation in Echelon Strategy Vault Deposit FunctionsInformationalSolved - 07/07/2025
Documentation Inconsistencies in Strategy CommentsInformationalSolved - 07/07/2025
Unused CodeInformationalSolved - 07/07/2025
Unnecessary Variable AssignmentsInformationalSolved - 07/07/2025
Inefficient Global Borrow of Strategy Resource in Rewards Pool SetterInformationalSolved - 07/07/2025

9. Findings & Tech Details

9.1 Fee Recipients Cannot Access Earned Fees in Meridian Strategy

//

Medium

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.2 Router's Meridian Strategy Deposit Path Mismatch Makes Strategy Inaccessible

//

Medium

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.3 Reward Notification Lacks Base Asset Exclusion Check

//

Low

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.4 Incorrect Balance Query in LayerBank Airdrop Block's claim_behalf Function

//

Low

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.5 Inconsistent Error Codes Across Strategy Implementations

//

Low

Description
BVSS
Recommendation
Remediation Comment

9.6 Permanent Upkeep Interval Limitation in LayerBank and Echelon Strategies

//

Low

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.7 Missing Validation of Rewards Pool Address

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.8 Missing Validation of Upkeep Interval Thresholds

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.9 Redundant State Update in Initial Rewards Pool Assignment

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.10 Missing Zero Amount Validation in Echelon Strategy Vault Deposit Functions

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.11 Documentation Inconsistencies in Strategy Comments

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.12 Unused Code

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.13 Unnecessary Variable Assignments

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

9.14 Inefficient Global Borrow of Strategy Resource in Rewards Pool Setter

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.