Solana LP Locker - UNCX Network

1. Introduction

UNCX engaged Halborn to conduct a security assessment on a set of changes int their LP Locker Solana program beginning on March 11th, 2024, and ending on March 20th, 2024. The security assessment was scoped to the Solana Program provided in solana-lp-locker-monorepo GitHub repository. Commit hashes and further details can be found in the Scope section of this report.

This set of changes is based on a new extension of the calculation of the intrinsic growth of an LP position due to commissions to allow a user who has locked LP to claim this commission component while keeping the initial main LP locked.

2. Assessment Summary

Halborn was provided 8 days for the engagement and assigned one full-time security engineer to review the security of the Solana Programs in scope. The engineer is a blockchain and smart contract security expert with advanced smart contract hacking skills, and deep knowledge of multiple blockchain protocols.

The purpose of the assessment is to:

• Identify potential security issues within the Solana Programs.

• Ensure that smart contract functionality operates as intended.

In summary, Halborn did not identify any significant security risks. However, some improvements were highlighted as best practices, which were acknowledged by the UNCX team:

• Add a check to validate the authority of user_token_coin and user_token_pc token accounts.

• Add validation to reject default public keys in change_owner and set_dev and remove the redundant check in in confirm_pending_admin

• Remove redundant fields in LpFeeCalc and TokenLock if they are not expected to be consumed in the program.

• Add a check before the fee calculation process to ensure that current_locked_amount is greater than zero and create a specific error case to explicitly handle the scenario where it is not.

3. Test Approach and Methodology

Halborn performed a combination of a manual review of the source code and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of the program assessment. While manual testing is recommended to uncover flaws in business logic, processes, and implementation; automated testing techniques help enhance coverage of programs and can quickly identify items that do not follow security best practices.

The following phases and associated tools were used throughout the term of the assessment:

• Research into the architecture, purpose, and use of the platform.

• Manual program source code review to identify business logic issues.

• Mapping out possible attack vectors

• Thorough assessment of safety and usage of critical Rust variables and functions in scope that could lead to arithmetic vulnerabilities.

• Scanning dependencies for known vulnerabilities (

  cargo audit

  ).
  

• Local runtime testing (

  cargo test-bpf

  )