Prepared by:
HALBORN
Last Updated Unknown date
Date of Engagement: April 22nd, 2024 - July 19th, 2024
100% of all REPORTED Findings have been addressed
All findings
24
Critical
0
High
0
Medium
1
Low
4
Informational
19
Concrete engaged Halborn to conduct a security assessment on their smart contracts. This report includes four assessments carried out on the following schedules:
Money Printer assessment beginning on April 22nd, 2024 and ending on May 1st, 2024.
Money Printer Code Updates assessment beginning on May 20th, 2024 and ending on June 5th, 2024.
Earn diff assessment beginning on June 10th, 2024 and ending on June 17th, 2024.
Silo and Radiant Strategies assessment beginning on July 16th, 2024 and ending on July 19th, 2024.
The team at Halborn was provided one week for the engagement and assigned a full-time security engineer to verify the security of the smart contract. The security engineer is a blockchain and smart-contract security expert with advanced penetration testing, smart-contract hacking, and deep knowledge of multiple blockchain protocols.
The purpose of this assessment is to:
Ensure that smart contract functions operate as intended.
Identify potential security issues with the smart contracts.
In summary, Halborn identified some security risks that were mostly addressed/acknowledged by the Concrete team.
Halborn performed a combination of manual and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of this assessment. While manual testing is recommended to uncover flaws in logic, process, and implementation; automated testing techniques help enhance coverage of the code and can quickly identify items that do not follow the security best practices. The following phases and associated tools were used during the assessment:
Research into architecture and purpose.
Smart contract manual code review and walkthrough.
Graphing out functionality and contract logic/connectivity/functions (solgraph).
Manual assessment of use and safety for the critical Solidity variables and functions in scope to identify any arithmetic related vulnerability classes.
Manual testing by custom scripts.
Testnet deployment (Foundry).
External libraries and financial-related attacks.
Files located under src/examples/* folder.
| EXPLOITABILITY METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Attack Origin (AO) | Arbitrary (AO:A) Specific (AO:S) | 1 0.2 |
| Attack Cost (AC) | Low (AC:L) Medium (AC:M) High (AC:H) | 1 0.67 0.33 |
| Attack Complexity (AX) | Low (AX:L) Medium (AX:M) High (AX:H) | 1 0.67 0.33 |
| IMPACT METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Confidentiality (C) | None (C:N) Low (C:L) Medium (C:M) High (C:H) Critical (C:C) | 0 0.25 0.5 0.75 1 |
| Integrity (I) | None (I:N) Low (I:L) Medium (I:M) High (I:H) Critical (I:C) | 0 0.25 0.5 0.75 1 |
| Availability (A) | None (A:N) Low (A:L) Medium (A:M) High (A:H) Critical (A:C) | 0 0.25 0.5 0.75 1 |
| Deposit (D) | None (D:N) Low (D:L) Medium (D:M) High (D:H) Critical (D:C) | 0 0.25 0.5 0.75 1 |
| Yield (Y) | None (Y:N) Low (Y:L) Medium (Y:M) High (Y:H) Critical (Y:C) | 0 0.25 0.5 0.75 1 |
| SEVERITY COEFFICIENT () | COEFFICIENT VALUE | NUMERICAL VALUE |
|---|---|---|
| Reversibility () | None (R:N) Partial (R:P) Full (R:F) | 1 0.5 0.25 |
| Scope () | Changed (S:C) Unchanged (S:U) | 1.25 1 |
| Severity | Score Value Range |
|---|---|
| Critical | 9 - 10 |
| High | 7 - 8.9 |
| Medium | 4.5 - 6.9 |
| Low | 2 - 4.4 |
| Informational | 0 - 1.9 |
Critical
0
High
0
Medium
1
Low
4
Informational
19
| Security analysis | Risk level | Remediation Date |
|---|---|---|
| Logic issue on vault removal | Medium | Solved - 07/29/2024 |
| Potential Denial of Service on prepare withdrawal function | Low | Risk Accepted |
| Denial of service on _getStrategy function | Low | Solved - 06/09/2024 |
| ClaimRouter contract is using a mock interface | Low | Risk Accepted |
| Unchecked Return Values of ERC20 Functions | Low | Solved - 07/29/2024 |
| Single step ownership transfer process | Informational | Acknowledged |
| Owner can renounce Ownership | Informational | Acknowledged |
| A single compromised account can lock up the protocol | Informational | Acknowledged |
| Potential denial of service on removeVault with block gas limit | Informational | Solved - 06/09/2024 |
| Checked increments in for loops increases gas consumption | Informational | Solved - 05/07/2024 |
| Incomplete Error Handling in retireStrategy | Informational | Solved - 07/29/2024 |
| Missing checks for index out of bounds | Informational | Solved - 05/07/2024 |
| Use external instead of public methods | Informational | Solved - 05/07/2024 |
| PUSH0 is not supported by all chains | Informational | Acknowledged |
| Missing zero address checks | Informational | Acknowledged |
| Checked increments in for loops increases gas consumption | Informational | Acknowledged |
| Lack of validation on ProtectStrategy | Informational | Acknowledged |
| Duplicated Imports | Informational | Solved - 07/30/2024 |
| Events for Function Calls | Informational | Acknowledged |
| Centralization risk: Lack of Access Control in requestFunds | Informational | Acknowledged |
| Missing zero address checks on constructor | Informational | Solved - 07/29/2024 |
| Unrestricted Reward Enabling | Informational | Acknowledged |
| Centralization risk: retireStrategy | Informational | Acknowledged |
| No Events for claim function | Informational | Acknowledged |
//Medium
//Low
//Low
//Low
//Low
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
//Informational
Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.
// Download the full report
Earn V1
* Use Google Chrome for best results
** Check "Background Graphics" in the print settings if needed
