Tangle Network Code Review - Tangle Tools

Prepared by:

HALBORN

Last Updated Unknown date

Date of Engagement: October 15th, 2024 - December 13th, 2024

Summary

100% of all REPORTED Findings have been addressed

All findings

Critical

High

Medium

Low

Informational

1. Introduction
2. Assessment summary
3. Test approach and methodology
4. Risk methodology
5. Scope
6. Assessment summary & findings overview
7. Findings & Tech Details

7.1 Missing pallet functionalities in corresponding precompiles makes it impossible to call them through evm contracts
7.2 Incorrect implementation of is_nominator in staking precompile
7.3 Unavailable features due to discrepancies between precompile and evm interface
7.4 Miscalculated selector of the transfernative log
7.5 Missing transfernative event in erc-20 interface implementation
7.6 Mismatch in return types between precompiles and evm interfaces
7.7 Potential overflow in deposit accumulation
7.8 Underflow in stake reduction
7.9 Missing unstake amount validation
7.10 Overflow in operator stake addition
7.11 Ensure apy and cap are within acceptable ranges
7.12 Missing existing stake reduction request validation
7.13 Underflow in gas calculation
7.14 Potential overflow in total supply update in mint_claim
7.15 Overflow risk in current_reward_counter commission calculation
7.16 Unhandled results in verify_signature! macro
7.17 Hardcoded gas limit and inconsistent error handling in on_register_hook
7.18 Missing era validation in dispute function
7.19 Insecure handling of invalid scalar decoding in decode
7.20 Possible underflow on balance reduction
7.21 Use distinct error for pending leave round
7.22 Presence of typos
7.23 Presence of todos
7.24 Erroneous documentation
7.25 Missing precompiles in tangle workspace
7.26 Compilation errors in `tangle-lst` precompile
7.27 Improper mocking and testing of the `tangle-lst` precompile
7.28 Redundant function in `services` precompile
7.29 Redundant operations in move_claim for identical addresses
7.30 Lack of validation for identity element in deserialize function

8. Automated Testing

1. Introduction

Tangle Network engaged Halborn to perform a security assessment of their Rust codebase from Oct. 15, 2024, to Dec. 13, 2024. The assessment focused on the substrate code, precompiled code, and pallets listed in the provided GitHub repository and included relevant commit hashes. More details can be found in the Scope section of this report.

2. Assessment Summary

The Halborn team was allocated 8 weeks and 3 days for the engagement and assigned two full-time security engineers to assess the security of the substrate pallets and the overall codebase. The security engineers are experts in blockchain and smart contract security, with advanced skills in penetration testing and smart contract auditing, as well as extensive knowledge of various blockchain protocols.

The purpose of this assessment is to:

Ensure that the codebase functions operate as intended, including properly implementing staking, pooling, reward mechanisms, and Ethereum compatibility features.
Identify potential security issues within the codebase, such as:
- Cryptographic vulnerabilities (e.g., signature malleability, replay attacks, or misuse of hashing functions).
- Logical inconsistencies in key functionalities like staking, unbonding, reward calculations.
- Dependency-related risks from external crates and libraries.
- Insufficient input validation or unchecked operations may lead to panics, overflows, or security exploits.
Verify that the code adheres to best practices for blockchain security, such as preventing unauthorized access, maintaining data integrity, and ensuring predictable execution under edge cases and adverse conditions.
Assess the implementation of Ethereum precompiles, proxy types, and EVM integration to ensure proper validation, safe asset handling, and gas usage efficiency.

3. Test Approach and Methodology

The Halborn team performed a combination of manual code review and automated security testing to ensure a comprehensive and efficient assessment of the Tangle codebase. This approach balanced efficiency, timeliness, practicality, and accuracy to address the assessment scope. Manual testing was used to uncover flaws in logic, process, and implementation, while automated tools were employed to quickly identify deviations from security best practices. The following phases and associated tools were used throughout the assessment:

Research on the architecture, purpose, and usage of the Tangle network.
Manual code walkthroughs to understand the design of key modules, including staking, pooling, reward distribution, and EVM precompiles, while identifying potential vulnerabilities.
Assessment of Rust functions and variables for arithmetic vulnerabilities, such as overflow/underflow or unsafe computations.
Audit of cryptographic protocols and primitives, including ECDSA signature recovery and Ethereum address mapping, to ensure compliance with industry standards and robustness against attacks.
Scanning Rust crates with Cargo Audit to identify outdated dependencies, known vulnerabilities, and insecure versions of third-party libraries.
Analyzing unsafe code usage with Cargo Geiger, ensuring minimal reliance on unsafe Rust features to reduce risks of memory safety vulnerabilities.
Validation of error handling and logging practices to prevent unintentional exposure of sensitive information or system behavior.

4. RISK METHODOLOGY

Every vulnerability and issue observed by Halborn is ranked based on two sets of Metrics and a Severity Coefficient. This system is inspired by the industry standard Common Vulnerability Scoring System.

The two Metric sets are: Exploitability and Impact. Exploitability captures the ease and technical means by which vulnerabilities can be exploited and Impact describes the consequences of a successful exploit.

The Severity Coefficients is designed to further refine the accuracy of the ranking with two factors: Reversibility and Scope. These capture the impact of the vulnerability on the environment as well as the number of users and smart contracts affected.

The final score is a value between 0-10 rounded up to 1 decimal place and 10 corresponding to the highest security risk. This provides an objective and accurate rating of the severity of security vulnerabilities in smart contracts.

The system is designed to assist in identifying and prioritizing vulnerabilities based on their level of risk to address the most critical issues in a timely manner.

4.1 EXPLOITABILITY

Attack Origin (AO):

Captures whether the attack requires compromising a specific account.

Attack Cost (AC):

Captures the cost of exploiting the vulnerability incurred by the attacker relative to sending a single transaction on the relevant blockchain. Includes but is not limited to financial and computational cost.

Attack Complexity (AX):

Describes the conditions beyond the attacker’s control that must exist in order to exploit the vulnerability. Includes but is not limited to macro situation, available third-party liquidity and regulatory challenges.

Metrics:

EXPLOITABILITY METRIC ( $m_e$ )	METRIC VALUE	NUMERICAL VALUE
Attack Origin (AO)	Arbitrary (AO:A) Specific (AO:S)	1 0.2
Attack Cost (AC)	Low (AC:L) Medium (AC:M) High (AC:H)	1 0.67 0.33
Attack Complexity (AX)	Low (AX:L) Medium (AX:M) High (AX:H)	1 0.67 0.33

Exploitability

E

is calculated using the following formula:

$E = \prod m_e$

4.2 IMPACT

Confidentiality (C):

Measures the impact to the confidentiality of the information resources managed by the contract due to a successfully exploited vulnerability. Confidentiality refers to limiting access to authorized users only.

Integrity (I):

Measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of data stored and/or processed on-chain. Integrity impact directly affecting Deposit or Yield records is excluded.

Availability (A):

Measures the impact to the availability of the impacted component resulting from a successfully exploited vulnerability. This metric refers to smart contract features and functionality, not state. Availability impact directly affecting Deposit or Yield is excluded.

Deposit (D):

Measures the impact to the deposits made to the contract by either users or owners.

Yield (Y):

Measures the impact to the yield generated by the contract for either users or owners.

Metrics:

IMPACT METRIC ( $m_I$ )	METRIC VALUE	NUMERICAL VALUE
Confidentiality (C)	None (C:N) Low (C:L) Medium (C:M) High (C:H) Critical (C:C)	0 0.25 0.5 0.75 1
Integrity (I)	None (I:N) Low (I:L) Medium (I:M) High (I:H) Critical (I:C)	0 0.25 0.5 0.75 1
Availability (A)	None (A:N) Low (A:L) Medium (A:M) High (A:H) Critical (A:C)	0 0.25 0.5 0.75 1
Deposit (D)	None (D:N) Low (D:L) Medium (D:M) High (D:H) Critical (D:C)	0 0.25 0.5 0.75 1
Yield (Y)	None (Y:N) Low (Y:L) Medium (Y:M) High (Y:H) Critical (Y:C)	0 0.25 0.5 0.75 1

Impact

I

is calculated using the following formula:

$I = max(m_I) + \frac{\sum{m_I} - max(m_I)}{4}$

4.3 SEVERITY COEFFICIENT

Reversibility (R):

Describes the share of the exploited vulnerability effects that can be reversed. For upgradeable contracts, assume the contract private key is available.

Scope (S):

Captures whether a vulnerability in one vulnerable contract impacts resources in other contracts.

Metrics:

SEVERITY COEFFICIENT ( $C$ )	COEFFICIENT VALUE	NUMERICAL VALUE
Reversibility ( $r$ )	None (R:N) Partial (R:P) Full (R:F)	1 0.5 0.25
Scope ( $s$ )	Changed (S:C) Unchanged (S:U)	1.25 1

Severity Coefficient

C

is obtained by the following product:

$C = rs$

The Vulnerability Severity Score

S

is obtained by:

$S = min(10, EIC * 10)$

The score is rounded up to 1 decimal places.

Severity	Score Value Range
Critical	9 - 10
High	7 - 8.9
Medium	4.5 - 6.9
Low	2 - 4.4
Informational	0 - 1.9

5. SCOPE

REPOSITORY

(a) Repository: tangle

(b) Assessed Commit ID: 57afc82

./precompiles/precompile-registry/src/lib.rs
./precompiles/precompile-registry/src/mock.rs
./precompiles/precompile-registry/src/file.rs
./precompiles/precompile-registry/PrecompileRegistry.sol
./precompiles/precompile-registry/Cargo.toml
./precompiles/proxy/src/lib.rs
./precompiles/proxy/src/mock.rs
./precompiles/proxy/Proxy.sol
./precompiles/proxy/Cargo.toml
./precompiles/verify-ecdsa-stark-signature/src/lib.rs
./precompiles/verify-ecdsa-stark-signature/src/mock.rs
./precompiles/verify-schnorr-signatures/src/lib.rs
./precompiles/verify-schnorr-signatures/src/mock.rs
./precompiles/preimage/src/lib.rs
./precompiles/preimage/src/mock.rs
./precompiles/preimage/Preimage.sol
./precompiles/preimage/Cargo.toml
./precompiles/multi-asset-delegation/src/lib.rs
./precompiles/multi-asset-delegation/src/mock.rs
./precompiles/multi-asset-delegation/MultiAssetDelegation.sol
./precompiles/multi-asset-delegation/Cargo.toml
./precompiles/assets-erc20/src/lib.rs
./precompiles/assets-erc20/src/mock.rs
./precompiles/assets-erc20/src/eip2612.rs
./precompiles/assets-erc20/ERC20.sol
./precompiles/assets-erc20/Cargo.toml
./precompiles/verify-ecdsa-secp256k1-signature/src/lib.rs
./precompiles/verify-ecdsa-secp256k1-signature/src/mock.rs
./precompiles/vesting/src/lib.rs
./precompiles/vesting/src/mock.rs
./precompiles/vesting/Vesting.sol
./precompiles/vesting/Cargo.toml
./precompiles/call-permit/src/lib.rs
./precompiles/call-permit/src/mock.rs
./precompiles/call-permit/CallPermit.sol
./precompiles/call-permit/Cargo.toml
./precompiles/verify-bls381-signature/src/lib.rs
./precompiles/verify-bls381-signature/src/mock.rs
./precompiles/batch/src/lib.rs
./precompiles/batch/src/mock.rs
./precompiles/batch/Batch.sol
./precompiles/batch/Cargo.toml
./precompiles/staking/src/lib.rs
./precompiles/staking/src/mock.rs
./precompiles/staking/StakingInterface.sol
./precompiles/staking/Cargo.toml
./precompiles/balances-erc20/src/lib.rs
./precompiles/balances-erc20/src/mock.rs
./precompiles/balances-erc20/src/eip2612.rs
./precompiles/balances-erc20/ERC20.sol
./precompiles/balances-erc20/Permit.sol
./precompiles/balances-erc20/Cargo.toml
./precompiles/pallet-democracy/src/lib.rs
./precompiles/pallet-democracy/src/mock.rs
./precompiles/pallet-democracy/DemocracyInterface.sol
./precompiles/pallet-democracy/Cargo.toml
./precompiles/verify-ecdsa-secp256r1-signature/src/lib.rs
./precompiles/verify-ecdsa-secp256r1-signature/src/mock.rs
./precompiles/services/src/lib.rs
./precompiles/services/src/mock_evm.rs
./precompiles/services/src/mock.rs
./precompiles/services/Services.sol
./precompiles/services/Cargo.toml
./precompiles/tangle-lst/src/lib.rs
./precompiles/tangle-lst/src/mock.rs
./precompiles/tangle-lst/src/tests.rs
./precompiles/tangle-lst/TangleLst.sol
./precompiles/tangle-lst/Cargo.toml
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/typenum-77bc54cafb08a928/out/consts.rs
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/typenum-77bc54cafb08a928/out/op.rs
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/crunchy-5a03cf7e8d26cafd/out/lib.rs
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/ss58-registry-6336a88cbc7b6988/out/registry_gen.rs
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/libsecp256k1-cb5f863cee0d0faf/out/const.rs
./target/release/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/libsecp256k1-cb5f863cee0d0faf/out/const_gen.rs
./target/release/wbuild/tangle-runtime/target/release/build/crunchy-817b753c24c2e88d/out/lib.rs
./target/release/wbuild/tangle-runtime/target/release/build/num-bigint-33da6836e9d65258/out/radix_bases.rs
./target/release/wbuild/tangle-runtime/target/release/build/typenum-4c91c07580b73cd9/out/consts.rs
./target/release/wbuild/tangle-runtime/target/release/build/typenum-4c91c07580b73cd9/out/op.rs
./target/release/wbuild/tangle-runtime/src/lib.rs
./target/release/build/sc-network-48acb25d39a8ddbf/out/bitswap.message.rs
./target/release/build/ss58-registry-1e82581a867b6486/out/registry_gen.rs
./target/release/build/libsqlite3-sys-3bed0484f0d04345/out/bindgen.rs
./target/release/build/num-bigint-6ac4efeb774a931c/out/radix_bases.rs
./target/release/build/librocksdb-sys-2061fd00eeacd0f1/out/bindings.rs
./target/release/build/crunchy-c0c056869d8756cb/out/lib.rs
./target/release/build/libsecp256k1-9aa143c96152cf17/out/const.rs
./target/release/build/libsecp256k1-9aa143c96152cf17/out/const_gen.rs
./target/release/build/crunchy-3912c6807ac9c604/out/lib.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/keys_proto.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/webrtc.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/kademlia.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/bitswap.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/identify.rs
./target/release/build/litep2p-825e2c81ef9c647b/out/noise.rs
./target/release/build/libsqlite3-sys-f73eed50fda0d737/out/bindgen.rs
./target/release/build/crunchy-d319590ed8895f73/out/lib.rs
./target/release/build/sc-network-sync-b8e1eaa7da826361/out/api.v1.rs
./target/release/build/typenum-1a033e2ebe306aa8/out/consts.rs
./target/release/build/typenum-1a033e2ebe306aa8/out/op.rs
./target/release/build/tangle-runtime-9866cf63990fbdd1/out/wasm_binary.rs
./target/release/build/names-250a5497e4c2ea43/out/adjectives.rs
./target/release/build/names-250a5497e4c2ea43/out/nouns.rs
./target/release/build/typenum-6d55275642aaa3c3/out/consts.rs
./target/release/build/typenum-6d55275642aaa3c3/out/op.rs
./target/release/build/oid-registry-db6f908e180e8262/out/oid_db.rs
./target/release/build/snap-ce4a9bce9706d371/out/crc32_table.rs
./target/release/build/snap-ce4a9bce9706d371/out/tag.rs
./target/release/build/sc-network-light-c7148cf9468f22d6/out/api.v1.light.rs
./target/release/build/target-lexicon-7328d64e37bb5158/out/host.rs
./target/release/build/clang-sys-d8823bbd5f55306c/out/macros.rs
./target/release/build/clang-sys-d8823bbd5f55306c/out/dynamic.rs
./target/release/build/clang-sys-d8823bbd5f55306c/out/common.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/isle_x64.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/isle_riscv64.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/types.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/inst_builder.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/opcodes.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/version.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/isle_opt.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/isle_aarch64.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/settings.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/isle_s390x.rs
./target/release/build/cranelift-codegen-f0bb2136ee3604f9/out/settings-arm64.rs
./target/release/build/ss58-registry-07453e54b9b92f38/out/registry_gen.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/typenum-77bc54cafb08a928/out/consts.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/typenum-77bc54cafb08a928/out/op.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/crunchy-5a03cf7e8d26cafd/out/lib.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/ss58-registry-6336a88cbc7b6988/out/registry_gen.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/libsecp256k1-cb5f863cee0d0faf/out/const.rs
./target/debug/wbuild/tangle-runtime/target/wasm32-unknown-unknown/release/build/libsecp256k1-cb5f863cee0d0faf/out/const_gen.rs
./target/debug/wbuild/tangle-runtime/target/release/build/crunchy-817b753c24c2e88d/out/lib.rs
./target/debug/wbuild/tangle-runtime/target/release/build/num-bigint-33da6836e9d65258/out/radix_bases.rs
./target/debug/wbuild/tangle-runtime/target/release/build/typenum-4c91c07580b73cd9/out/consts.rs
./target/debug/wbuild/tangle-runtime/target/release/build/typenum-4c91c07580b73cd9/out/op.rs
./target/debug/wbuild/tangle-runtime/src/lib.rs
./target/debug/build/ss58-registry-20acb3ab58930709/out/registry_gen.rs
./target/debug/build/libsqlite3-sys-b9bff05073b2bdc3/out/bindgen.rs
./target/debug/build/libsqlite3-sys-a6a57ba52f872856/out/bindgen.rs
./target/debug/build/ss58-registry-bee8f736ffce7254/out/registry_gen.rs
./target/debug/build/librocksdb-sys-3ef509e2018e6243/out/bindings.rs
./target/debug/build/libsecp256k1-db6f897c09712282/out/const.rs
./target/debug/build/libsecp256k1-db6f897c09712282/out/const_gen.rs
./target/debug/build/sc-network-sync-7c72eeae634f0d3a/out/api.v1.rs
./target/debug/build/target-lexicon-ba9fc21304e0517d/out/host.rs
./target/debug/build/librocksdb-sys-3ff61f6c56954feb/out/bindings.rs
./target/debug/build/crunchy-fe2317c9d0666412/out/lib.rs
./target/debug/build/clang-sys-55de9a41e0189c8d/out/macros.rs
./target/debug/build/clang-sys-55de9a41e0189c8d/out/dynamic.rs
./target/debug/build/clang-sys-55de9a41e0189c8d/out/common.rs
./target/debug/build/tangle-runtime-7d9363e879c64dfe/out/wasm_binary.rs
./target/debug/build/libsecp256k1-2db8b27eff37a28b/out/const.rs
./target/debug/build/libsecp256k1-2db8b27eff37a28b/out/const_gen.rs
./target/debug/build/librocksdb-sys-1499051134b0f4c9/out/bindings.rs
./target/debug/build/ss58-registry-9d72bbad9a6a0026/out/registry_gen.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/keys_proto.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/webrtc.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/kademlia.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/bitswap.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/identify.rs
./target/debug/build/litep2p-93a63ccb769f0f3d/out/noise.rs
./target/debug/build/crunchy-951ba8ec7c6ff06d/out/lib.rs
./target/debug/build/libsecp256k1-5df37734e70ab8f4/out/const.rs
./target/debug/build/libsecp256k1-5df37734e70ab8f4/out/const_gen.rs
./target/debug/build/eyre-1f0bc71a135e778b/out/probe.rs
./target/debug/build/sc-network-3c64d49df26f24c2/out/bitswap.message.rs
./target/debug/build/sc-network-sync-a253f4e672e33c3b/out/api.v1.rs
./target/debug/build/sc-network-0b75fd8a6029a04e/out/bitswap.message.rs
./target/debug/build/oid-registry-ff1eb8473a0b6605/out/oid_db.rs
./target/debug/build/typenum-532341fd88b943d3/out/consts.rs
./target/debug/build/typenum-532341fd88b943d3/out/op.rs
./target/debug/build/names-fb72d868f906686c/out/adjectives.rs
./target/debug/build/names-fb72d868f906686c/out/nouns.rs
./target/debug/build/snap-321bb9b9bddf47a0/out/crc32_table.rs
./target/debug/build/snap-321bb9b9bddf47a0/out/tag.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/keys_proto.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/webrtc.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/kademlia.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/bitswap.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/identify.rs
./target/debug/build/litep2p-4340ba08af4aae23/out/noise.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/isle_x64.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/isle_riscv64.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/types.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/inst_builder.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/opcodes.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/version.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/isle_opt.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/isle_aarch64.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/settings.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/isle_s390x.rs
./target/debug/build/cranelift-codegen-62508f5f7766311c/out/settings-arm64.rs
./target/debug/build/tangle-runtime-75cf208497fdc5cc/out/wasm_binary.rs
./target/debug/build/sc-network-light-4dc7bac958c804b9/out/api.v1.light.rs
./target/debug/build/sc-network-light-6bd9d049ac8a2b20/out/api.v1.light.rs
./target/debug/build/crunchy-43b34cbd98de8e37/out/lib.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/keys_proto.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/webrtc.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/kademlia.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/bitswap.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/identify.rs
./target/debug/build/litep2p-357e2bb63ad6e8aa/out/noise.rs
./target/debug/build/ss58-registry-700ce32cebb3e128/out/registry_gen.rs
./target/debug/build/tangle-runtime-a070ffad155ae093/out/wasm_binary.rs
./target/debug/build/num-bigint-707b2ddfcd40bae4/out/radix_bases.rs
./target/debug/build/sc-network-light-e831188416a15206/out/api.v1.light.rs
./target/debug/build/sc-network-sync-2242bd334acf79f5/out/api.v1.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/isle_x64.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/isle_riscv64.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/types.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/inst_builder.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/opcodes.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/version.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/isle_opt.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/isle_aarch64.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/settings.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/isle_s390x.rs
./target/debug/build/cranelift-codegen-f2cda8eec827df3b/out/settings-arm64.rs
./target/debug/build/sc-network-bfbab2dab31ef86e/out/bitswap.message.rs
./frost/frost-ristretto255/src/types.rs
./frost/frost-ristretto255/src/lib.rs
./frost/frost-p384/src/types.rs
./frost/frost-p384/src/lib.rs
./frost/frost-p256/src/types.rs
./frost/frost-p256/src/lib.rs
./frost/frost-secp256k1/src/types.rs
./frost/frost-secp256k1/src/lib.rs
./frost/frost-ed448/src/types.rs
./frost/frost-ed448/src/lib.rs
./frost/frost-ed25519/src/types.rs
./frost/frost-ed25519/src/lib.rs
./frost/frost-taproot/src/types.rs
./frost/frost-taproot/src/lib.rs
./frost/src/keys.rs
./frost/src/verifying_key.rs
./frost/src/util.rs
./frost/src/scalar_mul.rs
./frost/src/error.rs
./frost/src/lib.rs
./frost/src/serialization.rs
./frost/src/challenge.rs
./frost/src/signing_key.rs
./frost/src/keygen.rs
./frost/src/signature.rs
./frost/src/identifier.rs
./frost/src/round1.rs
./frost/src/traits.rs
./frost/src/const_crc32.rs
./runtime/mainnet/build.rs
./runtime/mainnet/src/frontier_evm.rs
./runtime/mainnet/src/tangle_services.rs
./runtime/mainnet/src/lib.rs
./runtime/mainnet/src/impls.rs
./runtime/mainnet/src/filters.rs
./runtime/mainnet/src/precompiles.rs
./runtime/mainnet/src/voter_bags.rs
./runtime/mainnet/src/migrations.rs
./evm-tracer/src/lib.rs
./primitives/crypto/src/lib.rs
./primitives/ext/src/lib.rs
./primitives/rpc/evm-tracing-events/src/runtime.rs
./primitives/rpc/evm-tracing-events/src/evm.rs
./primitives/rpc/evm-tracing-events/src/lib.rs
./primitives/rpc/evm-tracing-events/src/gasometer.rs
./primitives/rpc/txpool/src/lib.rs
./primitives/rpc/debug/src/lib.rs
./primitives/src/types.rs
./primitives/src/traits/services.rs
./primitives/src/traits/mod.rs
./primitives/src/traits/multi_asset_delegation.rs
./primitives/src/lib.rs
./primitives/src/impls.rs
./primitives/src/verifier/mod.rs
./primitives/src/verifier/arkworks.rs
./primitives/src/verifier/circom.rs
./primitives/src/chain_identifier.rs
./primitives/src/services/field.rs
./primitives/src/services/mod.rs
./tangle-subxt/src/lib.rs
./tangle-subxt/src/tangle_mainnet_runtime.rs
./pallets/multi-asset-delegation/src/types.rs
./pallets/multi-asset-delegation/src/types/operator.rs
./pallets/multi-asset-delegation/src/types/delegator.rs
./pallets/multi-asset-delegation/src/types/rewards.rs
./pallets/multi-asset-delegation/src/lib.rs
./pallets/multi-asset-delegation/src/functions.rs
./pallets/multi-asset-delegation/src/mock.rs
./pallets/multi-asset-delegation/src/weights.rs
./pallets/multi-asset-delegation/src/functions/operator.rs
./pallets/multi-asset-delegation/src/functions/session_manager.rs
./pallets/multi-asset-delegation/src/functions/delegate.rs
./pallets/multi-asset-delegation/src/functions/deposit.rs
./pallets/multi-asset-delegation/src/functions/rewards.rs
./pallets/multi-asset-delegation/src/traits.rs
./pallets/services/rpc/runtime-api/src/lib.rs
./pallets/services/rpc/src/lib.rs
./pallets/services/src/types.rs
./pallets/services/src/lib.rs
./pallets/services/src/functions.rs
./pallets/services/src/mock_evm.rs
./pallets/services/src/impls.rs
./pallets/services/src/mock.rs
./pallets/services/src/weights.rs
./pallets/services/src/traits.rs
./pallets/services/src/rpc.rs
./pallets/claims/src/lib.rs
./pallets/claims/src/utils/mod.rs
./pallets/claims/src/utils/ethereum_address.rs
./pallets/claims/src/mock.rs
./pallets/claims/src/weights.rs
./pallets/tangle-lst/src/types/pools.rs
./pallets/tangle-lst/src/types/sub_pools.rs
./pallets/tangle-lst/src/types/commission.rs
./pallets/tangle-lst/src/types/mod.rs
./pallets/tangle-lst/src/types/bonded_pool.rs
./pallets/tangle-lst/src/lib.rs
./pallets/tangle-lst/src/mock.rs
./pallets/tangle-lst/src/weights.rs
./node/build.rs
./node/src/command.rs
./node/src/lib.rs
./node/src/manual_seal.rs
./node/src/eth.rs
./node/src/chainspec/mainnet.rs
./node/src/chainspec/mod.rs
./node/src/service.rs
./node/src/mainnet_fixtures.rs
./node/src/main.rs
./node/src/rpc/eth.rs
./node/src/rpc/tracing.rs
./node/src/rpc/mod.rs
./node/src/distributions/mainnet.rs
./node/src/distributions/mod.rs
./node/src/distributions/develop.rs
./node/src/utils.rs
./node/src/cli.rs
./client/rpc-core/types/src/lib.rs
./client/rpc-core/trace/src/lib.rs
./client/rpc-core/txpool/src/types/mod.rs
./client/rpc-core/txpool/src/types/inspect.rs
./client/rpc-core/txpool/src/types/content.rs
./client/rpc-core/txpool/src/lib.rs
./client/rpc-core/debug/src/lib.rs
./client/evm-tracing/src/types/single.rs
./client/evm-tracing/src/types/serialization.rs
./client/evm-tracing/src/types/mod.rs
./client/evm-tracing/src/types/block.rs
./client/evm-tracing/src/lib.rs
./client/evm-tracing/src/formatters/raw.rs
./client/evm-tracing/src/formatters/mod.rs
./client/evm-tracing/src/formatters/call_tracer.rs
./client/evm-tracing/src/formatters/trace_filter.rs
./client/evm-tracing/src/formatters/blockscout.rs
./client/evm-tracing/src/listeners/raw.rs
./client/evm-tracing/src/listeners/mod.rs
./client/evm-tracing/src/listeners/call_list.rs
./client/rpc/trace/src/lib.rs
./client/rpc/txpool/src/lib.rs
./client/rpc/debug/src/lib.rs
./Cargo.toml
tangle-network/tangle/pull/794

./precompiles/precompile-registry/src/lib.rs
./precompiles/precompile-registry/src/mock.rs
./precompiles/precompile-registry/src/file.rs

↓ Expand ↓

Out-of-Scope: Third party dependencies and economic attacks.

Out-of-Scope: New features/implementations after the remediation commit IDs.

6. Assessment Summary & Findings Overview

Critical

High

Medium

Low

Informational

Security analysis	Risk level	Remediation Date
Missing Pallet Functionalities In Corresponding Precompiles Makes It Impossible To Call Them Through EVM Contracts	High	Solved - 01/21/2025
Incorrect Implementation Of is_nominator In Staking Precompile	Medium	Solved - 01/20/2025
Unavailable Features Due to Discrepancies Between Precompile and EVM Interface	Medium	Solved - 01/21/2025
Miscalculated Selector Of The TransferNative Log	Low	Solved - 01/20/2025
Missing TransferNative Event in ERC-20 Interface Implementation	Low	Solved - 01/20/2025
Mismatch in Return Types Between Precompiles and EVM Interfaces	Low	Solved - 01/21/2025
Potential Overflow in Deposit Accumulation	Informational	Solved - 01/19/2025
Underflow in Stake Reduction	Informational	Solved - 01/19/2025
Missing Unstake Amount validation	Informational	Solved - 01/19/2025
Overflow in Operator Stake Addition	Informational	Solved - 01/19/2025
Ensure APY and Cap Are Within Acceptable Ranges	Informational	Solved - 01/19/2025
Missing Existing Stake Reduction Request Validation	Informational	Solved - 01/19/2025
Underflow in Gas Calculation	Informational	Solved - 01/19/2025
Potential Overflow in Total Supply Update in mint_claim	Informational	Solved - 01/19/2025
Overflow Risk in current_reward_counter Commission Calculation	Informational	Solved - 01/19/2025
Unhandled Results in verify_signature! Macro	Informational	Solved - 01/19/2025
Hardcoded Gas Limit and Inconsistent Error Handling in on_register_hook	Informational	Solved - 01/19/2025
Missing Era Validation in dispute Function	Informational	Not Applicable
Insecure Handling of Invalid Scalar Decoding in decode	Informational	Solved - 01/19/2025
Possible Underflow on Balance Reduction	Informational	Solved - 01/19/2025
Use Distinct Error for Pending Leave Round	Informational	Solved - 01/19/2025
Presence Of Typos	Informational	Solved - 01/21/2025
Presence Of TODOs	Informational	Solved - 01/21/2025
Erroneous Documentation	Informational	Solved - 01/21/2025
Missing Precompiles in Tangle Workspace	Informational	Solved - 01/21/2025
Compilation Errors In `tangle-lst` Precompile	Informational	Solved - 11/07/2024
Improper Mocking And Testing Of The `tangle-lst` Precompile	Informational	Solved - 11/07/2024
Redundant Function In `services` Precompile	Informational	Solved - 12/19/2024
Redundant Operations in move_claim for Identical Addresses	Informational	Solved - 01/19/2025
Lack of Validation for Identity Element in deserialize Function	Informational	Solved - 01/19/2025

Remediation Comment

7.8 Underflow in Stake Reduction

Informational

8. Automated Testing

Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.

1. Introduction
2. Assessment summary
3. Test approach and methodology
4. Risk methodology
5. Scope
6. Assessment summary & findings overview
7. Findings & Tech Details

7.1 Missing pallet functionalities in corresponding precompiles makes it impossible to call them through evm contracts
7.2 Incorrect implementation of is_nominator in staking precompile
7.3 Unavailable features due to discrepancies between precompile and evm interface
7.4 Miscalculated selector of the transfernative log
7.5 Missing transfernative event in erc-20 interface implementation
7.6 Mismatch in return types between precompiles and evm interfaces
7.7 Potential overflow in deposit accumulation
7.8 Underflow in stake reduction
7.9 Missing unstake amount validation
7.10 Overflow in operator stake addition
7.11 Ensure apy and cap are within acceptable ranges
7.12 Missing existing stake reduction request validation
7.13 Underflow in gas calculation
7.14 Potential overflow in total supply update in mint_claim
7.15 Overflow risk in current_reward_counter commission calculation
7.16 Unhandled results in verify_signature! macro
7.17 Hardcoded gas limit and inconsistent error handling in on_register_hook
7.18 Missing era validation in dispute function
7.19 Insecure handling of invalid scalar decoding in decode
7.20 Possible underflow on balance reduction
7.21 Use distinct error for pending leave round
7.22 Presence of typos
7.23 Presence of todos
7.24 Erroneous documentation
7.25 Missing precompiles in tangle workspace
7.26 Compilation errors in `tangle-lst` precompile
7.27 Improper mocking and testing of the `tangle-lst` precompile
7.28 Redundant function in `services` precompile
7.29 Redundant operations in move_claim for identical addresses
7.30 Lack of validation for identity element in deserialize function