Solana Agg Settlement Program Audit | 0x Project

Summary

100% of all REPORTED Findings have been addressed

About this report

Assessment Type

Assurance Assessment

Date of Engagement

March 24th, 2025 - March 28th, 2025

Source Code

sol-settler sol-settler

Assessed Commit ID

13410f6 9f33067

Severity Breakdown

0Acknowledged
0Risk Accepted
3Solved
3All Findings

Critical0
High0
Medium0
Low0
Informational3
- 3Solved

Introduction#

ZeroEx engaged Halborn to conduct a security assessment on sol-settler program beginning on March 24th, 2025 and ending on March 28th, 2025. The security assessment was scoped to the smart contracts provided in the GitHub repository sol-settler, commit hashes and further details can be found in the Scope section of this report.

The ZeroEx team is releasing the sol-settler program, an onchain settlement program to support swap routes from an offchain aggregation service.

During the security assessment a new action was added, pumpswap_buy, which allows users to trade tokens directly from liquidity pools without intermediaries through Pump Swap, a decentralized exchange which relies on an automated market maker (AMM) system.

Assessment Summary#

Halborn was provided 5 days for the engagement and assigned one full-time security engineer to review the security of the Solana Programs in scope. The engineer is a blockchain and smart contract security expert with advanced smart contract hacking skills, and deep knowledge of multiple blockchain protocols.

The purpose of the assessment is to:

Identify potential security issues within the Solana Program.
Ensure that smart contract functionality operates as intended.

In summary, Halborn did not identify any significant security risks. However, some improvements were highlighted that were addressed by the ZeroEx team. The main ones were the following:

Add a check to ensure the provided wsol_mint_account corresponds to the native SOL mint.
Validate that amount_in is not lower than the actual balance of the sell account before processing any actions.
Replace expect() with structured error-handling mechanisms.

Test Approach and Methodology#

Halborn performed a combination of a manual review of the source code and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of the program assessment. While manual testing is recommended to uncover flaws in business logic, processes, and implementation; automated testing techniques help enhance coverage of programs and can quickly identify items that do not follow security best practices.

The following phases and associated tools were used throughout the term of the assessment:

Research into the architecture, purpose, and use of the platform.
Manual program source code review to identify business logic issues.
Mapping out possible attack vectors
Thorough assessment of safety and usage of critical Rust variables and functions in scope that could lead to arithmetic vulnerabilities.
Scanning dependencies for known vulnerabilities (cargo audit).
Local runtime testing (cargo test)

Risk Methodology#

Every vulnerability and issue observed by Halborn is ranked based on two sets of Metrics and a Severity Coefficient. This system is inspired by the industry standard Common Vulnerability Scoring System.

The two Metric sets are: Exploitability and Impact. Exploitability captures the ease and technical means by which vulnerabilities can be exploited and Impact describes the consequences of a successful exploit.

The Severity Coefficients is designed to further refine the accuracy of the ranking with two factors: Reversibility and Scope. These capture the impact of the vulnerability on the environment as well as the number of users and smart contracts affected.

The final score is a value between 0-10 rounded up to 1 decimal place and 10 corresponding to the highest security risk. This provides an objective and accurate rating of the severity of security vulnerabilities in smart contracts.

The system is designed to assist in identifying and prioritizing vulnerabilities based on their level of risk to address the most critical issues in a timely manner.

4.1 EXPLOITABILITY

Attack Origin (AO):

Captures whether the attack requires compromising a specific account.

Attack Cost (AC):

Captures the cost of exploiting the vulnerability incurred by the attacker relative to sending a single transaction on the relevant blockchain. Includes but is not limited to financial and computational cost.

Attack Complexity (AX):

Describes the conditions beyond the attacker’s control that must exist in order to exploit the vulnerability. Includes but is not limited to macro situation, available third-party liquidity and regulatory challenges.

Metrics:

EXPLOITABILITY METRIC ( $m_e$ )	METRIC VALUE	NUMERICAL VALUE
Attack Origin (AO)	Arbitrary (AO:A)	1
Attack Origin (AO)	Specific (AO:S)	0.2
Attack Cost (AC)	Low (AC:L)	1
	Medium (AC:M)	0.67
	High (AC:H)	0.33
Attack Complexity (AX)	Low (AX:L)	1
	Medium (AX:M)	0.67
	High (AX:H)	0.33

Exploitability

E

is calculated using the following formula:

$E = \prod m_e$

4.2 IMPACT

Confidentiality (C):

Measures the impact to the confidentiality of the information resources managed by the contract due to a successfully exploited vulnerability. Confidentiality refers to limiting access to authorized users only.

Integrity (I):

Measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of data stored and/or processed on-chain. Integrity impact directly affecting Deposit or Yield records is excluded.

Availability (A):

Measures the impact to the availability of the impacted component resulting from a successfully exploited vulnerability. This metric refers to smart contract features and functionality, not state. Availability impact directly affecting Deposit or Yield is excluded.

Deposit (D):

Measures the impact to the deposits made to the contract by either users or owners.

Yield (Y):

Measures the impact to the yield generated by the contract for either users or owners.

Metrics:

IMPACT METRIC ( $m_I$ )	METRIC VALUE	NUMERICAL VALUE
Confidentiality (C)	None (C:N)	0
	Low (C:L)	0.25
	Medium (C:M)	0.5
	High (C:H)	0.75
	Critical (C:C)	1
Integrity (I)	None (I:N)	0
	Low (I:L)	0.25
	Medium (I:M)	0.5
	High (I:H)	0.75
	Critical (I:C)	1
Availability (A)	None (A:N)	0
	Low (A:L)	0.25
	Medium (A:M)	0.5
	High (A:H)	0.75
	Critical (A:C)	1
Deposit (D)	None (D:N)	0
	Low (D:L)	0.25
	Medium (D:M)	0.5
	High (D:H)	0.75
	Critical (D:C)	1
Yield (Y)	None (Y:N)	0
	Low (Y:L)	0.25
	Medium (Y:M)	0.5
	High (Y:H)	0.75
	Critical (Y:C)	1

Impact

I

is calculated using the following formula:

$I = max(m_I) + \frac{\sum{m_I} - max(m_I)}{4}$

4.3 SEVERITY COEFFICIENT

Reversibility (R):

Describes the share of the exploited vulnerability effects that can be reversed. For upgradeable contracts, assume the contract private key is available.

Scope (S):

Captures whether a vulnerability in one vulnerable contract impacts resources in other contracts.

Metrics:

SEVERITY COEFFICIENT ( $C$ )	COEFFICIENT VALUE	NUMERICAL VALUE
Reversibility ( $r$ )	None (R:N)	1
	Partial (R:P)	0.5
	Full (R:F)	0.25
Scope ( $s$ )	Changed (S:C)	1.25
Scope ( $s$ )	Unchanged (S:U)	1

Severity Coefficient

C

is obtained by the following product:

$C = rs$

The Vulnerability Severity Score

S

is obtained by:

$S = min(10, EIC * 10)$

The score is rounded up to 1 decimal places.

Critical	High	Medium	Low	Informational
9 - 10	7 - 8.9	4.5 - 6.9	2 - 4.4	0 - 1.9

Scope#

(a) Repository:sol-settler

(b) Assessed Commit ID:13410f64cbf97afd4880e5d89293e1f5355fccb3

25 files

sol-settler-main / program

25 files

src

24 files

dexes

5 files

pumpfun

4 files

accounts.rs

rust

id.rs

rust

instructions.rs

rust

mod.rs

rust

mod.rs

rust

processor

12 files

actions

10 files

action_trait.rs

rust

Out-of-Scope:Third party dependencies and economic attacks.

(a) Repository:sol-settler

(b) Assessed Commit ID:9f33067196d472916aee680a35b5e3377b2b66a8

10 files

program / src

10 files

dexes

5 files

pumpswap_amm

4 files

accounts.rs

rust

id.rs

rust

math.rs

rust

mod.rs

rust

mod.rs

rust

processor

3 files

actions

2 files

mod.rs

rust

pumpswap_buy.rs

rust

Out-of-Scope:Third party dependencies and economic attacks.

3909555fad08fcb3e7aad0fd70301d9b8894a8df

Out-of-Scope: New features/implementations after the remediation commit IDs.

Assessment Summary & Findings Overview#

#	Title	Severity	Score	Status
HAL-01	Lack of wsol mint validation	Informational	1.4	Solved04/04/2025
HAL-02	Lack of amount in validation against sell account balance	Informational	1.3	Solved04/05/2025
HAL-03	Improper use of expect() after checked arithmetic leading to uncontrolled panics	Informational	0.0	Solved04/05/2025

Findings & Tech Details#

HAL-01Solved

Lack of wsol mint validation

Informational

1.4AO:S/AC:L/AX:L/R:N/S:U/C:N/A:L/I:M/D:M/Y:NAO:S/AC:L/AX:L/R:N/S:U/C:N/A:L/I:M/D:M/Y:N

Description

Recommendation

Remediation Comment

Addressed in:

3909555fad08fcb3e7aad0fd70301d9b8894a8df

HAL-02Solved

Lack of amount in validation against sell account balance

Informational

1.3AO:S/AC:L/AX:L/R:N/S:U/C:N/A:M/I:N/D:M/Y:NAO:S/AC:L/AX:L/R:N/S:U/C:N/A:M/I:N/D:M/Y:N

Description

Recommendation

Remediation Comment

Addressed in:

3909555fad08fcb3e7aad0fd70301d9b8894a8df

HAL-03Solved

Improper use of expect() after checked arithmetic leading to uncontrolled panics

Informational

0.0AO:A/AC:L/AX:L/R:N/S:U/C:N/A:N/I:N/D:N/Y:NAO:A/AC:L/AX:L/R:N/S:U/C:N/A:N/I:N/D:N/Y:N

Description

Recommendation

Remediation Comment

Addressed in:

3909555fad08fcb3e7aad0fd70301d9b8894a8df

8. Automated Testing#

Disclaimer#

Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.