NGL Bridge + Gorples Bridge Audit | Entangle.fi

Summary

100% of all REPORTED Findings have been addressed

About this report

Assessment Type

Assurance Assessment

Date of Engagement

May 23rd, 2024 - June 21st, 2024

Source Code

ngl-bridge gorples-solana

Assessed Commit ID

e1c7fe8 https://github.com/Entangle-Protocol/borpa-solana/tree/89634681f1f6c9028faa646bff413fda1d4fabf4

Severity Breakdown

1Partially Solved
1Acknowledged
1Risk Accepted
1Solved
4All Findings

Critical1
- 1Solved
High1
- 1P. Solved
Medium0
Low1
- 1Risk A.
Informational1
- 1Ack.

Introduction#

Entangle Labs team engaged Halborn to conduct a security assessment on their ngl-core, ngl-bridge and gorples-bridge Solana programs beginning on May 23rd, 2024 and ending on June 21st, 2024. The security assessment was scoped to the Solana Programs provided in ngl-core, ngl-bridge , and gorples-bridge GitHub repositories. Commit hashes and further details can be found in the Scope section of this report.

Ngl-core is a token owner program, used by ngl-bridge program to mint and burn tokens
Ngl-bridge is a bridge program, called by Photon CCM endpoint, to receive tokens from other networks or the user to send tokens to other networks.
Gorples Bridge program is a token bridge compatible with Entangle CCM

Assessment Summary#

Halborn was provided 4 weeks for the engagement and assigned one full-time security engineer to review the security of the Solana Programs in scope. The engineer is a blockchain and smart contract security expert with advanced smart contract hacking skills, and deep knowledge of multiple blockchain protocols.

The purpose of the assessment is to:

Identify potential security issues within the Solana Programs.
Ensure that smart contract functionality operates as intended.

In summary, Halborn identified some improvements to reduce the likelihood and impact of multiple risks, which has been partially addressed by Entangle Labs team. The main ones were the following:

Gorples Bridge Program initializer can be front-run
Fee Collector Vault check missing can lead to DoS in PhotonMsg

Note: Testing is a crucial component of our methodology for conducting security assessments. It enables us to identify potential security risks and program malfunctions, as well as to emulate the exploitation of these risks.

However, during this security assessment, the Entangle Labs team did not provide a test suite that facilitates interaction with the in-scope bridge programs. This significantly limited our ability to perform security tests on certain parts of the program, such as bridge and photon msg. Consequently, we were unable to execute our methodology fully and were restricted to conducting only an exhaustive code review of these components. This limitation has prevented us from guaranteeing 100% code security.

Test Approach and Methodology#

Halborn performed a combination of a manual review of the source code and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of the program assessment. While manual testing is recommended to uncover flaws in business logic, processes, and implementation; automated testing techniques help enhance coverage of programs and can quickly identify items that do not follow security best practices.

The following phases and associated tools were used throughout the term of the assessment:

- Research into the architecture, purpose, and use of the platform.

- Manual program source code review to identify business logic issues.

- Mapping out possible attack vectors

- Thorough assessment of safety and usage of critical Rust variables and functions in scope that could lead to arithmetic vulnerabilities.

- Scanning dependencies for known vulnerabilities (

cargo audit

- Local runtime testing (

solana-test-framework

Risk Methodology#

Every vulnerability and issue observed by Halborn is ranked based on two sets of Metrics and a Severity Coefficient. This system is inspired by the industry standard Common Vulnerability Scoring System.

The two Metric sets are: Exploitability and Impact. Exploitability captures the ease and technical means by which vulnerabilities can be exploited and Impact describes the consequences of a successful exploit.

The Severity Coefficients is designed to further refine the accuracy of the ranking with two factors: Reversibility and Scope. These capture the impact of the vulnerability on the environment as well as the number of users and smart contracts affected.

The final score is a value between 0-10 rounded up to 1 decimal place and 10 corresponding to the highest security risk. This provides an objective and accurate rating of the severity of security vulnerabilities in smart contracts.

The system is designed to assist in identifying and prioritizing vulnerabilities based on their level of risk to address the most critical issues in a timely manner.

4.1 EXPLOITABILITY

Attack Origin (AO):

Captures whether the attack requires compromising a specific account.

Attack Cost (AC):

Captures the cost of exploiting the vulnerability incurred by the attacker relative to sending a single transaction on the relevant blockchain. Includes but is not limited to financial and computational cost.

Attack Complexity (AX):

Describes the conditions beyond the attacker’s control that must exist in order to exploit the vulnerability. Includes but is not limited to macro situation, available third-party liquidity and regulatory challenges.

Metrics:

EXPLOITABILITY METRIC ( $m_e$ )	METRIC VALUE	NUMERICAL VALUE
Attack Origin (AO)	Arbitrary (AO:A)	1
Attack Origin (AO)	Specific (AO:S)	0.2
Attack Cost (AC)	Low (AC:L)	1
	Medium (AC:M)	0.67
	High (AC:H)	0.33
Attack Complexity (AX)	Low (AX:L)	1
	Medium (AX:M)	0.67
	High (AX:H)	0.33

Exploitability

E

is calculated using the following formula:

$E = \prod m_e$

4.2 IMPACT

Confidentiality (C):

Measures the impact to the confidentiality of the information resources managed by the contract due to a successfully exploited vulnerability. Confidentiality refers to limiting access to authorized users only.

Integrity (I):

Measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of data stored and/or processed on-chain. Integrity impact directly affecting Deposit or Yield records is excluded.

Availability (A):

Measures the impact to the availability of the impacted component resulting from a successfully exploited vulnerability. This metric refers to smart contract features and functionality, not state. Availability impact directly affecting Deposit or Yield is excluded.

Deposit (D):

Measures the impact to the deposits made to the contract by either users or owners.

Yield (Y):

Measures the impact to the yield generated by the contract for either users or owners.

Metrics:

IMPACT METRIC ( $m_I$ )	METRIC VALUE	NUMERICAL VALUE
Confidentiality (C)	None (C:N)	0
	Low (C:L)	0.25
	Medium (C:M)	0.5
	High (C:H)	0.75
	Critical (C:C)	1
Integrity (I)	None (I:N)	0
	Low (I:L)	0.25
	Medium (I:M)	0.5
	High (I:H)	0.75
	Critical (I:C)	1
Availability (A)	None (A:N)	0
	Low (A:L)	0.25
	Medium (A:M)	0.5
	High (A:H)	0.75
	Critical (A:C)	1
Deposit (D)	None (D:N)	0
	Low (D:L)	0.25
	Medium (D:M)	0.5
	High (D:H)	0.75
	Critical (D:C)	1
Yield (Y)	None (Y:N)	0
	Low (Y:L)	0.25
	Medium (Y:M)	0.5
	High (Y:H)	0.75
	Critical (Y:C)	1

Impact

I

is calculated using the following formula:

$I = max(m_I) + \frac{\sum{m_I} - max(m_I)}{4}$

4.3 SEVERITY COEFFICIENT

Reversibility (R):

Describes the share of the exploited vulnerability effects that can be reversed. For upgradeable contracts, assume the contract private key is available.

Scope (S):

Captures whether a vulnerability in one vulnerable contract impacts resources in other contracts.

Metrics:

SEVERITY COEFFICIENT ( $C$ )	COEFFICIENT VALUE	NUMERICAL VALUE
Reversibility ( $r$ )	None (R:N)	1
	Partial (R:P)	0.5
	Full (R:F)	0.25
Scope ( $s$ )	Changed (S:C)	1.25
Scope ( $s$ )	Unchanged (S:U)	1

Severity Coefficient

C

is obtained by the following product:

$C = rs$

The Vulnerability Severity Score

S

is obtained by:

$S = min(10, EIC * 10)$

The score is rounded up to 1 decimal places.

Critical	High	Medium	Low	Informational
9 - 10	7 - 8.9	4.5 - 6.9	2 - 4.4	0 - 1.9

Scope#

(a) Repository:ngl-bridge

(b) Assessed Commit ID:e1c7fe87a00ff6b1d29b132c70d23adb10183364

8 files

programs

8 files

ngl-bridge

7 files

instructions

5 files

bridge.rs

rust

initialize.rs

rust

photon_msg.rs

rust

set_admin.rs

rust

set_bridge_config.rs

rust

lib.rs

rust

states.rs

rust

ngl-core / src

1 file

lib.rs

rust

(a) Repository:gorples-solana

(b) Assessed Commit ID:https://github.com/Entangle-Protocol/borpa-solana/tree/89634681f1f6c9028faa646bff413fda1d4fabf4

6 files

borpa-bridge / src

6 files

instructions

4 files

bridge.rs

rust

initialize.rs

rust

photon_msg.rs

rust

set_bridge_config.rs

rust

lib.rs

rust

state.rs

rust

Out-of-Scope: New features/implementations after the remediation commit IDs.

Assessment Summary & Findings Overview#

#	Title	Severity	Score	Status
HAL-01	GORPLES BRIDGE PROGRAM INITIALIZER CAN BE FRONT-RUN	Critical	10.0	Solved06/22/2024
HAL-02	FEE COLLECTOR VAULT CHECK MISSING CAN LEAD TO DOS IN PHOTONMSG	High	7.5	Partially Solved07/16/2024
HAL-03	UNVALIDATED BRIDGE AUTHORITY COULD LEAD TO IRREVERSIBLE ERRORS AND DOS	Low	3.4	Risk Accepted
HAL-04	NEW ADMIN NOT VALIDATED	Informational	1.6	Acknowledged

Findings & Tech Details#

HAL-01Solved

GORPLES BRIDGE PROGRAM INITIALIZER CAN BE FRONT-RUN

Critical

10.0AO:A/AC:L/AX:L/C:N/I:M/A:M/D:C/Y:C/R:N/S:UAO:A/AC:L/AX:L/C:N/I:M/A:M/D:C/Y:C/R:N/S:U

Description

Proof of Concept

Recommendation

HAL-02Partially Solved

FEE COLLECTOR VAULT CHECK MISSING CAN LEAD TO DOS IN PHOTONMSG

High

7.5AO:A/AC:L/AX:L/C:N/I:M/A:M/D:N/Y:M/R:N/S:UAO:A/AC:L/AX:L/C:N/I:M/A:M/D:N/Y:M/R:N/S:U

Description

Proof of Concept

Recommendation

HAL-03Risk Accepted

UNVALIDATED BRIDGE AUTHORITY COULD LEAD TO IRREVERSIBLE ERRORS AND DOS

Low

3.4AO:S/AC:L/AX:L/C:N/I:C/A:C/D:C/Y:H/R:N/S:UAO:S/AC:L/AX:L/C:N/I:C/A:C/D:C/Y:H/R:N/S:U

Description

Recommendation

HAL-04Acknowledged

NEW ADMIN NOT VALIDATED

Informational

1.6AO:S/AC:L/AX:L/C:N/I:H/A:L/D:N/Y:N/R:N/S:UAO:S/AC:L/AX:L/C:N/I:H/A:L/D:N/Y:N/R:N/S:U

Description

Recommendation

8. Automated Testing#

Disclaimer#

Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.