Bera LRT Contracts - Lair Finance


Prepared by:

Halborn Logo

HALBORN

Last Updated 07/28/2025

Date of Engagement: June 10th, 2025 - June 19th, 2025

Summary

100% of all REPORTED Findings have been addressed

All findings

20

Critical

2

High

7

Medium

3

Low

1

Informational

7


1. Introduction

Lair Finance engaged Halborn to conduct a security assessment of their smart contracts from June 10th to June 19th, 2025, with a follow-up review from July 19th to July 23rd, 2025. The scope of this assessment was limited to the smart contracts provided to the Halborn team. Commit hashes and additional details are documented in the Scope section of this report.

2. Assessment Summary

The Halborn team dedicated a total of twelve days to this engagement, deploying one full-time security engineer to evaluate the smart contracts’ security posture.

The assigned security engineer is an expert in blockchain and smart contract security, with advanced skills in penetration testing, smart contract exploitation, and a comprehensive understanding of multiple blockchain protocols.

The objectives of this assessment were to:

    • Verify that the smart contract functions operate as intended.

    • Identify potential security vulnerabilities within the smart contracts.

In summary, Halborn identified several areas for improvement to reduce both the likelihood and impact of potential risks. The Lair Finance team has partially addressed some of these recommendations. The primary suggestions include:

    • Restrict receivedToken() to internal calls to prevent unauthorized token transfers by approved users.

    • Use correct decimals for price calculations in reward swaps.

    • Verify proper Kodiak interface usage.

    • Correct arithmetic underflow in the getTokenAmountByToken1 function to prevent staking denial-of-service (DoS) via token1.

    • Fix incorrect refund logic in _stake to prevent staking reverts caused by ERC20InsufficientBalance errors.

    • Address unit mismatch between BGT and WBERA tokens during token0 swap to prevent DoS in token0 staking.

    • Mitigate front-running attacks on reward harvesting by integrating reward execution within stake and unstake flows.

    • Implement a safe token approval mechanism compatible with tokens like USDT to prevent reverts.

    • Incorporate slippage protection in reward token swaps to defend against MEV extraction.

    • Follow established smart contract best practices.

3. Test Approach and Methodology

Halborn employed a combination of manual, semi-automated, and automated security testing methods to ensure effectiveness, efficiency, and accuracy within the scope of this assessment. Manual testing was vital for uncovering issues related to logic, processes, and implementation details, while automated techniques enhanced code coverage and helped identify deviations from security best practices. The assessment involved the following phases and tools:

    • Research into the architecture and purpose of the smart contracts.

    • Manual review and walkthrough of the smart contract code.

    • Manual evaluation of critical Solidity variables and functions to identify potential vulnerability classes.

    • Manual testing using custom scripts.

    • Static security analysis of the scoped contracts and imported functions utilizing Slither.

    • Local deployment and testing with Foundry.


4. RISK METHODOLOGY

Every vulnerability and issue observed by Halborn is ranked based on two sets of Metrics and a Severity Coefficient. This system is inspired by the industry standard Common Vulnerability Scoring System.
The two Metric sets are: Exploitability and Impact. Exploitability captures the ease and technical means by which vulnerabilities can be exploited and Impact describes the consequences of a successful exploit.
The Severity Coefficients is designed to further refine the accuracy of the ranking with two factors: Reversibility and Scope. These capture the impact of the vulnerability on the environment as well as the number of users and smart contracts affected.
The final score is a value between 0-10 rounded up to 1 decimal place and 10 corresponding to the highest security risk. This provides an objective and accurate rating of the severity of security vulnerabilities in smart contracts.
The system is designed to assist in identifying and prioritizing vulnerabilities based on their level of risk to address the most critical issues in a timely manner.

4.1 EXPLOITABILITY

Attack Origin (AO):
Captures whether the attack requires compromising a specific account.
Attack Cost (AC):
Captures the cost of exploiting the vulnerability incurred by the attacker relative to sending a single transaction on the relevant blockchain. Includes but is not limited to financial and computational cost.
Attack Complexity (AX):
Describes the conditions beyond the attacker’s control that must exist in order to exploit the vulnerability. Includes but is not limited to macro situation, available third-party liquidity and regulatory challenges.
Metrics:
EXPLOITABILITY METRIC (mem_e)METRIC VALUENUMERICAL VALUE
Attack Origin (AO)Arbitrary (AO:A)
Specific (AO:S)
1
0.2
Attack Cost (AC)Low (AC:L)
Medium (AC:M)
High (AC:H)
1
0.67
0.33
Attack Complexity (AX)Low (AX:L)
Medium (AX:M)
High (AX:H)
1
0.67
0.33
Exploitability EE is calculated using the following formula:

E=meE = \prod m_e

4.2 IMPACT

Confidentiality (C):
Measures the impact to the confidentiality of the information resources managed by the contract due to a successfully exploited vulnerability. Confidentiality refers to limiting access to authorized users only.
Integrity (I):
Measures the impact to integrity of a successfully exploited vulnerability. Integrity refers to the trustworthiness and veracity of data stored and/or processed on-chain. Integrity impact directly affecting Deposit or Yield records is excluded.
Availability (A):
Measures the impact to the availability of the impacted component resulting from a successfully exploited vulnerability. This metric refers to smart contract features and functionality, not state. Availability impact directly affecting Deposit or Yield is excluded.
Deposit (D):
Measures the impact to the deposits made to the contract by either users or owners.
Yield (Y):
Measures the impact to the yield generated by the contract for either users or owners.
Metrics:
IMPACT METRIC (mIm_I)METRIC VALUENUMERICAL VALUE
Confidentiality (C)None (C:N)
Low (C:L)
Medium (C:M)
High (C:H)
Critical (C:C)
0
0.25
0.5
0.75
1
Integrity (I)None (I:N)
Low (I:L)
Medium (I:M)
High (I:H)
Critical (I:C)
0
0.25
0.5
0.75
1
Availability (A)None (A:N)
Low (A:L)
Medium (A:M)
High (A:H)
Critical (A:C)
0
0.25
0.5
0.75
1
Deposit (D)None (D:N)
Low (D:L)
Medium (D:M)
High (D:H)
Critical (D:C)
0
0.25
0.5
0.75
1
Yield (Y)None (Y:N)
Low (Y:L)
Medium (Y:M)
High (Y:H)
Critical (Y:C)
0
0.25
0.5
0.75
1
Impact II is calculated using the following formula:

I=max(mI)+mImax(mI)4I = max(m_I) + \frac{\sum{m_I} - max(m_I)}{4}

4.3 SEVERITY COEFFICIENT

Reversibility (R):
Describes the share of the exploited vulnerability effects that can be reversed. For upgradeable contracts, assume the contract private key is available.
Scope (S):
Captures whether a vulnerability in one vulnerable contract impacts resources in other contracts.
Metrics:
SEVERITY COEFFICIENT (CC)COEFFICIENT VALUENUMERICAL VALUE
Reversibility (rr)None (R:N)
Partial (R:P)
Full (R:F)
1
0.5
0.25
Scope (ss)Changed (S:C)
Unchanged (S:U)
1.25
1
Severity Coefficient CC is obtained by the following product:

C=rsC = rs

The Vulnerability Severity Score SS is obtained by:

S=min(10,EIC10)S = min(10, EIC * 10)

The score is rounded up to 1 decimal places.
SeverityScore Value Range
Critical9 - 10
High7 - 8.9
Medium4.5 - 6.9
Low2 - 4.4
Informational0 - 1.9

5. SCOPE

REPOSITORY
(a) Repository: bughole-lsd
(b) Assessed Commit ID: 8f7bf8b
(c) Items in scope:
  • contracts/bera/infrared/IMultiRewards.sol
  • contracts/bera/kodiak/IslandRouter.sol
  • contracts/bera/kodiak/IKodiakIsland.sol
↓ Expand ↓
Out-of-Scope: Third party dependencies and economic attacks.
Remediation Commit ID:
Out-of-Scope: New features/implementations after the remediation commit IDs.

6. Assessment Summary & Findings Overview

Critical

2

High

7

Medium

3

Low

1

Informational

7

Security analysisRisk levelRemediation Date
Token1 Single-Stake Function Permanent DoS Due to Arithmetic UnderflowCriticalSolved - 06/26/2025
Incorrect Refund Calculation causes Permanent Staking DoSCriticalSolved - 07/26/2025
Token Decimal Mismatch in Reward SwapsHighSolved - 07/25/2025
Incorrect Minimum Swap Amount for Non-18 Decimal TokensHighSolved - 07/26/2025
Oracle Interface Mismatch DoSHighSolved - 07/24/2025
Unauthorized Fund Transfer Vulnerability Enables Token Theft from Approved UsersHighSolved - 07/25/2025
Unit Mismatch Causes Permanent Staking Failures for Token0HighSolved - 06/26/2025
Step-Wise Jumps In the Reward System Allows Attacker To Steal RewardsHighSolved - 06/26/2025
MEV Extraction via Zero-Slippage Reward SwapsHighSolved - 06/26/2025
Unsafe Token Approval PatternMediumSolved - 06/26/2025
Potential Flash Loan Oracle ManipulationMediumRisk Accepted - 07/26/2025
Stale Ratio Parameters Could Affect Legitimate Function CallsMediumRisk Accepted - 07/25/2025
Division by Zero in Ratio CalculationsLowAcknowledged - 07/26/2025
Hard-coded Slippage in LP Reward Staking Could Cause RevertsInformationalSolved - 06/26/2025
Misleading Function NamesInformationalAcknowledged - 07/26/2025
Duplicate Code in Swap FunctionsInformationalAcknowledged - 07/26/2025
Inconsistent Error MessagesInformationalAcknowledged - 07/26/2025
Magic Numbers Without Named ConstantsInformationalAcknowledged - 07/26/2025
Missing NatSpec DocumentationInformationalAcknowledged - 07/26/2025
Missing Event Emission for Critical Configuration ChangesInformationalSolved - 06/26/2025

7. Findings & Tech Details

7.1 Token1 Single-Stake Function Permanent DoS Due to Arithmetic Underflow

//

Critical

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.2 Incorrect Refund Calculation causes Permanent Staking DoS

//

Critical

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.3 Token Decimal Mismatch in Reward Swaps

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.4 Incorrect Minimum Swap Amount for Non-18 Decimal Tokens

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.5 Oracle Interface Mismatch DoS

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.6 Unauthorized Fund Transfer Vulnerability Enables Token Theft from Approved Users

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.7 Unit Mismatch Causes Permanent Staking Failures for Token0

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.8 Step-Wise Jumps In the Reward System Allows Attacker To Steal Rewards

//

High

Description
Proof of Concept
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.9 MEV Extraction via Zero-Slippage Reward Swaps

//

High

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.10 Unsafe Token Approval Pattern

//

Medium

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.11 Potential Flash Loan Oracle Manipulation

//

Medium

Description
BVSS
Recommendation
Remediation Comment

7.12 Stale Ratio Parameters Could Affect Legitimate Function Calls

//

Medium

Description
BVSS
Recommendation
Remediation Comment

7.13 Division by Zero in Ratio Calculations

//

Low

Description
BVSS
Recommendation
Remediation Comment

7.14 Hard-coded Slippage in LP Reward Staking Could Cause Reverts

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

7.15 Misleading Function Names

//

Informational

Description
BVSS
Recommendation
Remediation Comment

7.16 Duplicate Code in Swap Functions

//

Informational

Description
BVSS
Recommendation
Remediation Comment

7.17 Inconsistent Error Messages

//

Informational

Description
BVSS
Recommendation
Remediation Comment

7.18 Magic Numbers Without Named Constants

//

Informational

Description
BVSS
Recommendation
Remediation Comment

7.19 Missing NatSpec Documentation

//

Informational

Description
BVSS
Recommendation
Remediation Comment

7.20 Missing Event Emission for Critical Configuration Changes

//

Informational

Description
BVSS
Recommendation
Remediation Comment
Remediation Hash

8. Automated Testing

Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.