Summary
100% of all REPORTED Findings have been addressed
- 5Partially Solved
- 4Acknowledged
- 3Risk Accepted
- 10Solved
- 22All Findings
- Critical0
- High0
- Medium0
- Low7
- 2Solved
- 2P. Solved
- 3Risk A.
- Informational15
- 4Ack.
- 3P. Solved
- 8Solved
Introduction#
Ten Protocol engaged Halborn to conduct a security assessment on their smart contracts beginning on May 5th, 2025 and ending on May 8th, 2025. The security assessment was scoped to the smart contracts provided to Halborn. Commit hashes and further details can be found in the Scope section of this report.
The Ten Protocol codebase in scope mainly consists of an infrastructure with an upgradeable token system, cross-chain messaging, and transaction processing mechanisms.
Assessment Summary#
Halborn was provided 4 days for the engagement and assigned 1 full-time security engineer to review the security of the smart contracts in scope. The engineer is a blockchain and smart contract security expert with advanced penetration testing and smart contract hacking skills, and deep knowledge of multiple blockchain protocols.
The purpose of the assessment is to:
Identify potential security issues within the smart contracts.
Ensure that smart contract functionality operates as intended.
In summary, Halborn identified some improvements to reduce the likelihood and impact of risks, which were partially addressed by the Ten Protocol team. The main ones are the following:
Add validation in the canReattemptCallback modifier to ensure the callbackId exists.Consider adding functionality to allow callback originators to cancel their pending callbacks when they're no longer needed or desired.Consider implementing a comprehensive callback management system.
Test Approach and Methodology#
Halborn performed a combination of manual review of the code and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of this assessment. While manual testing is recommended to uncover flaws in logic, process, and implementation; automated testing techniques help enhance coverage of smart contracts and can quickly identify items that do not follow security best practices.
The following phases and associated tools were used throughout the term of the assessment:
Research into architecture, purpose and use of the platform.
Smart contract manual code review and walkthrough to identify any logic issue.
Thorough assessment of safety and usage of critical Solidity variables and functions in scope that could led to arithmetic related vulnerabilities.
Local testing with custom scripts (
Foundry).Fork testing against main networks (
Foundry).Static analysis of security for scoped contract, and imported functions (
Slither).
Risk Methodology#
4.1 EXPLOITABILITY
Attack Origin (AO):
Attack Cost (AC):
Attack Complexity (AX):
Metrics:
| EXPLOITABILITY METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Attack Origin (AO) | Arbitrary (AO:A) | 1 |
| Specific (AO:S) | 0.2 | |
| Attack Cost (AC) | Low (AC:L) | 1 |
| Medium (AC:M) | 0.67 | |
| High (AC:H) | 0.33 | |
| Attack Complexity (AX) | Low (AX:L) | 1 |
| Medium (AX:M) | 0.67 | |
| High (AX:H) | 0.33 |
4.2 IMPACT
Confidentiality (C):
Integrity (I):
Availability (A):
Deposit (D):
Yield (Y):
Metrics:
| IMPACT METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Confidentiality (C) | None (C:N) | 0 |
| Low (C:L) | 0.25 | |
| Medium (C:M) | 0.5 | |
| High (C:H) | 0.75 | |
| Critical (C:C) | 1 | |
| Integrity (I) | None (I:N) | 0 |
| Low (I:L) | 0.25 | |
| Medium (I:M) | 0.5 | |
| High (I:H) | 0.75 | |
| Critical (I:C) | 1 | |
| Availability (A) | None (A:N) | 0 |
| Low (A:L) | 0.25 | |
| Medium (A:M) | 0.5 | |
| High (A:H) | 0.75 | |
| Critical (A:C) | 1 | |
| Deposit (D) | None (D:N) | 0 |
| Low (D:L) | 0.25 | |
| Medium (D:M) | 0.5 | |
| High (D:H) | 0.75 | |
| Critical (D:C) | 1 | |
| Yield (Y) | None (Y:N) | 0 |
| Low (Y:L) | 0.25 | |
| Medium (Y:M) | 0.5 | |
| High (Y:H) | 0.75 | |
| Critical (Y:C) | 1 |
4.3 SEVERITY COEFFICIENT
Reversibility (R):
Scope (S):
Metrics:
| SEVERITY COEFFICIENT () | COEFFICIENT VALUE | NUMERICAL VALUE |
|---|---|---|
| Reversibility () | None (R:N) | 1 |
| Partial (R:P) | 0.5 | |
| Full (R:F) | 0.25 | |
| Scope () | Changed (S:C) | 1.25 |
| Unchanged (S:U) | 1 |
| Critical | High | Medium | Low | Informational |
| 9 - 10 | 7 - 8.9 | 4.5 - 6.9 | 2 - 4.4 | 0 - 1.9 |
Scope#
Assessment Summary & Findings Overview#
# | Title | Severity | Score | Status |
|---|---|---|---|---|
| Missing validation of callbackId existence in canReattemptCallback modifier | Low | 3.1 | Solved05/20/2025 | |
| Lack of callback cancellation and lifecycle controls | Low | 2.5 | Solved05/20/2025 | |
| Inadequate callback array management | Low | 2.3 | Partially Solved05/20/2025 | |
| Single step ownership transfer process | Low | 2.0 | Partially Solved05/20/2025 | |
| Fixed token minting regardless of transaction value | Low | 2.0 | Risk Accepted06/11/2025 | |
| Lack of transaction processing tracking mechanism | Low | 2.0 | Risk Accepted06/11/2025 | |
| Missing error handling for callbacks | Low | 2.0 | Risk Accepted06/11/2025 | |
| Unnecessary external call in _internalRefund when refund amount is zero | Informational | 1.7 | Acknowledged06/11/2025 | |
| Missing input validation | Informational | 1.5 | Partially Solved05/20/2025 | |
| Use of low-level transfer method | Informational | 1.0 | Solved05/20/2025 | |
| Floating pragma | Informational | 1.0 | Acknowledged06/11/2025 | |
| Use of revert strings instead of custom errors | Informational | 0.8 | Acknowledged06/11/2025 | |
| Unhandled return value in _payForCallback Function | Informational | 0.8 | Acknowledged06/11/2025 | |
| Missing events | Informational | 0.6 | Solved05/20/2025 | |
| Open To-Dos | Informational | 0.4 | Partially Solved05/20/2025 | |
| Redundant default value assignment | Informational | 0.3 | Solved05/20/2025 | |
| Public functions can be marked external | Informational | 0.3 | Solved05/20/2025 | |
| Commented functionality | Informational | 0.2 | Partially Solved05/20/2025 | |
| Missing variable visibility | Informational | 0.2 | Solved05/20/2025 | |
| Lack of named mappings | Informational | 0.1 | Solved05/20/2025 | |
| Unused import | Informational | 0.0 | Solved05/20/2025 | |
| Unoptimized for loops | Informational | 0.0 | Solved05/20/2025 |
Findings & Tech Details#
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Remediation Comment
Description
Recommendation
Remediation Comment
Description
Recommendation
Remediation Comment
Description
Recommendation
Remediation Comment
Description
Recommendation
Description
Recommendation
Description
Recommendation
Remediation Comment
Description
Recommendation
Remediation Comment
Description
Recommendation
Remediation Comment
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
Description
Recommendation
8. Automated Testing#
Disclaimer#
Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.
