Prepared by:
HALBORN
Last Updated Unknown date
Date of Engagement: August 5th, 2024 - September 11th, 2024
100% of all REPORTED Findings have been addressed
All findings
6
Critical
0
High
1
Medium
1
Low
2
Informational
2
Zenrock engaged Halborn to conduct a security assessment on their modules, beginning on Halborn to conduct a security assessment on the appchain modules, beginning on 08/05/2024 and ending on 09/11/2024. The security assessment was scoped to the sections of code that pertain to the modules. Commit hashes and further details can be found in the Scope section of this report.
Halborn was provided 4 weeks for the engagement and assigned 1 full-time security engineer to review the security of the smart contracts in scope. The engineer is a blockchain and smart contract security experts with advanced penetration testing and smart contract hacking skills, and deep knowledge of multiple blockchain protocols.
The purpose of the assessment is to:
- Ensure that the Zenrock Chain Modules operate as intended.
- Identify potential security issues with the Zenrock Chain Modules in the Zenrock Chain.
In summary, Halborn identified some security concerns that were mostly addressed by the Zenrock team.
Halborn performed a combination of manual and automated security testing to balance efficiency, timeliness, practicality, and accuracy in regard to the scope of the custom modules. While manual testing is recommended to uncover flaws in logic, process, and implementation; automated testing techniques help enhance coverage of structures and can quickly identify items that do not follow security best practices. The following phases and associated tools were used throughout the term of the assessment:
- Research into architecture and purpose.
- Static Analysis of security for scoped repository, and imported functions. (e.g., staticcheck, gosec, unconvert, codeql, ineffassign and semgrep)
- Manual Assessment for discovering security vulnerabilities in the codebase.
- Ensuring the correctness of the codebase.
- Dynamic Analysis of files and modules related to the modules.
| EXPLOITABILITY METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Attack Origin (AO) | Arbitrary (AO:A) Specific (AO:S) | 1 0.2 |
| Attack Cost (AC) | Low (AC:L) Medium (AC:M) High (AC:H) | 1 0.67 0.33 |
| Attack Complexity (AX) | Low (AX:L) Medium (AX:M) High (AX:H) | 1 0.67 0.33 |
| IMPACT METRIC () | METRIC VALUE | NUMERICAL VALUE |
|---|---|---|
| Confidentiality (C) | None (C:N) Low (C:L) Medium (C:M) High (C:H) Critical (C:C) | 0 0.25 0.5 0.75 1 |
| Integrity (I) | None (I:N) Low (I:L) Medium (I:M) High (I:H) Critical (I:C) | 0 0.25 0.5 0.75 1 |
| Availability (A) | None (A:N) Low (A:L) Medium (A:M) High (A:H) Critical (A:C) | 0 0.25 0.5 0.75 1 |
| Deposit (D) | None (D:N) Low (D:L) Medium (D:M) High (D:H) Critical (D:C) | 0 0.25 0.5 0.75 1 |
| Yield (Y) | None (Y:N) Low (Y:L) Medium (Y:M) High (Y:H) Critical (Y:C) | 0 0.25 0.5 0.75 1 |
| SEVERITY COEFFICIENT () | COEFFICIENT VALUE | NUMERICAL VALUE |
|---|---|---|
| Reversibility () | None (R:N) Partial (R:P) Full (R:F) | 1 0.5 0.25 |
| Scope () | Changed (S:C) Unchanged (S:U) | 1.25 1 |
| Severity | Score Value Range |
|---|---|
| Critical | 9 - 10 |
| High | 7 - 8.9 |
| Medium | 4.5 - 6.9 |
| Low | 2 - 4.4 |
| Informational | 0 - 1.9 |
Critical
0
High
1
Medium
1
Low
2
Informational
2
| Security analysis | Risk level | Remediation Date |
|---|---|---|
| Unhandled Error in AddApprover Call Within ApproveAction Function | High | Solved - 09/09/2024 |
| Implement Support for ERC-20 transferFrom Method in ParseEthereumTransaction | Medium | Solved - 09/10/2024 |
| Implement PartyThreshold Validation in NewKeyring Function | Low | Solved - 09/09/2024 |
| Implement Expiration Date Utilization in AddMultiGrant Function | Low | Risk Accepted |
| Lack of spec on the modules | Informational | Solved - 09/15/2024 |
| Open TO-DOs | Informational | Acknowledged |
//High
//Medium
//Low
//Low
//Informational
//Informational
Halborn strongly recommends conducting a follow-up assessment of the project either within six months or immediately following any material changes to the codebase, whichever comes first. This approach is crucial for maintaining the project’s integrity and addressing potential vulnerabilities introduced by code modifications.
// Download the full report
Zrchain
* Use Google Chrome for best results
** Check "Background Graphics" in the print settings if needed
